-
Notifications
You must be signed in to change notification settings - Fork 25.3k
add EIS rerank default inference endpoint #129681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brendan-jugan-elastic
merged 10 commits into
elastic:main
from
brendan-jugan-elastic:eis-rerank-default-inference-endpoint
Jun 23, 2025
Merged
add EIS rerank default inference endpoint #129681
brendan-jugan-elastic
merged 10 commits into
elastic:main
from
brendan-jugan-elastic:eis-rerank-default-inference-endpoint
Jun 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Pinging @elastic/search-eng (Team:SearchOrg) |
timgrein
approved these changes
Jun 23, 2025
timgrein
reviewed
Jun 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up question: do we need to have separate tests for rerank in InferenceRevokeDefaultEndpointsIT
?
jonathan-buttner
approved these changes
Jun 23, 2025
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Jun 25, 2025
…lastic#129681) * add Elastic Inference Service rerank default inference endpoint * [CI] Auto commit changes from spotless * fix integ tests * update mock Elastic Inference Service authorization response * fix rerank service test --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit cef717c) # Conflicts: # x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceGetServicesIT.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
…lastic#129681) * add Elastic Inference Service rerank default inference endpoint * [CI] Auto commit changes from spotless * fix integ tests * update mock Elastic Inference Service authorization response * fix rerank service test --------- Co-authored-by: elasticsearchmachine <[email protected]>
brendan-jugan-elastic
added a commit
that referenced
this pull request
Jun 26, 2025
…erank (#129681) (#129985) * add default inference endpoint for Elastic Inference Service rerank (#129681) * add Elastic Inference Service rerank default inference endpoint * [CI] Auto commit changes from spotless * fix integ tests * update mock Elastic Inference Service authorization response * fix rerank service test --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit cef717c) # Conflicts: # x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceGetServicesIT.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java * Fix InferenceGetServicesIT rerank integration test * Fix InferenceGetServicesIT rerank integration test * spotlessApply * Fix integration test --------- Co-authored-by: Brendan Jugan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:SearchOrg/Inference
Label for the Search Inference team
Team:Search - Inference
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the rerank default inference endpoint for the Elastic Inference Service. This changes makes a few assumptions:
rerank-v1
.rerank-v1-elastic
rerank/text/text-similarity
->TaskType.RERANK
Testing
My testing included basic chat completions and sparse embeddings requests using the existing default endpoints with
eis-gateway
andeis-ray
running locally, to ensure existing functionality works as expected. I've also modified the authorized models in my localeis-gateway
, restarted ES, and verified that the list of default endpoints includes the new one for rerank.Chat Completions:
Sparse Embeddings:
Default Endpoints: