Switch from string to enum for metrics #5627
Open
+719
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
flobernd
reviewed
Nov 7, 2025
| sparse_vector | ||
| } | ||
|
|
||
| export type CommonStatsFlags = CommonStatsFlag | CommonStatsFlag[] |
There was a problem hiding this comment.
Could we please introduce an alias like this in all the other places as well instead of inlining the "single or many"?
This would allow me (and potential other consumers) to translate this construct into a native C# Flags enum for improved usability.
flobernd
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not including descriptions for now, this will be next step. I'm hopeful that the Docs team can help me for that.
Is the way I've added enums specific to an API in the Request files OK?