-
Notifications
You must be signed in to change notification settings - Fork 115
Implement union type validation for static language support #5603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
372a180
d003b69
90afbf8
dda5822
f8784ec
6424ec7
274ca87
10d6d66
6e8c9af
0baddb1
1819245
16b1a82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,11 +84,13 @@ export class IndexSettings | |
| * @server_default 1 | ||
| * @availability stack | ||
| * */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| number_of_shards?: integer | string // TODO: should be only int | ||
|
Comment on lines
+87
to
88
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the record, this a known issue with index settings that they can be passed as strings too.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should actually be Stringyfied I think. |
||
| /** | ||
| * @server_default 0 | ||
| * @availability stack | ||
| * */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| number_of_replicas?: integer | string // TODO: should be only int | ||
| number_of_routing_shards?: integer | ||
| /** @server_default false */ | ||
|
|
@@ -100,6 +102,7 @@ export class IndexSettings | |
| /** @server_default true */ | ||
| load_fixed_bitset_filters_eagerly?: boolean | ||
| /** @server_default false */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| hidden?: boolean | string // TODO should be bool only | ||
| /** @server_default false */ | ||
| auto_expand_replicas?: WithNullValue<string> | ||
|
|
@@ -147,11 +150,14 @@ export class IndexSettings | |
| creation_date_string?: DateTime | ||
| uuid?: Uuid | ||
| version?: IndexVersioning | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| verified_before_close?: boolean | string | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| format?: string | integer | ||
| max_slices_per_scroll?: integer | ||
| translog?: Translog | ||
| query_string?: SettingsQueryString | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| priority?: integer | string | ||
| top_metrics_max_size?: integer | ||
| analysis?: IndexSettingsAnalysis | ||
|
|
@@ -332,6 +338,7 @@ export class IndexSettingsLifecycle { | |
| * applicable for an index). | ||
| * @server_default true | ||
| */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| prefer_ilm?: boolean | string | ||
| } | ||
|
|
||
|
|
@@ -448,6 +455,7 @@ export class MappingLimitSettings { | |
| field_name_length?: MappingLimitSettingsFieldNameLength | ||
| dimension_fields?: MappingLimitSettingsDimensionFields | ||
| source?: MappingLimitSettingsSourceFields | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| ignore_malformed?: boolean | string | ||
| } | ||
|
|
||
|
|
@@ -458,6 +466,7 @@ export class MappingLimitSettingsTotalFields { | |
| * degradations and memory issues, especially in clusters with a high load or few resources. | ||
| * @server_default 1000 | ||
| */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| limit?: long | string | ||
| /** | ||
| * This setting determines what happens when a dynamically mapped field would exceed the total fields limit. When set | ||
|
|
@@ -467,6 +476,7 @@ export class MappingLimitSettingsTotalFields { | |
| * The fields that were not added to the mapping will be added to the _ignored field. | ||
| * @server_default false | ||
| */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions -- TODO: create named alias | ||
| ignore_dynamic_beyond_limit?: boolean | string | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,6 +55,7 @@ export class RoleDescriptor { | |
| * An object defining global privileges. A global privilege is a form of cluster privilege that is request-aware. Support for global privileges is currently limited to the management of application privileges. | ||
| * @availability stack | ||
| */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions, es-spec-validator/prefer-tagged-variants -- TODO: use tagged variant | ||
| global?: GlobalPrivilege[] | GlobalPrivilege | ||
| /** | ||
| * A list of application privilege entries | ||
|
|
@@ -106,6 +107,7 @@ export class RoleDescriptorRead implements OverloadOf<RoleDescriptor> { | |
| /** | ||
| * An object defining global privileges. A global privilege is a form of cluster privilege that is request-aware. Support for global privileges is currently limited to the management of application privileges. | ||
| */ | ||
| // eslint-disable-next-line es-spec-validator/no-inline-unions, es-spec-validator/prefer-tagged-variants -- TODO: use tagged variant | ||
| global?: GlobalPrivilege[] | GlobalPrivilege | ||
|
||
| /** | ||
| * A list of application privilege entries | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.