[samples] remove unneeded file_storage and fix a bug #10856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
|
VihasMakwana
added
skip-changelog
backport-active-all
|
I think #10826 should be addressed here, it doesn't seem like adding a basic unit test that the collector starts is that much work. If it is a lot of work let me know and we can discuss a better strategy to address this. |
pchila
reviewed
Oct 28, 2025
swiatekm
reviewed
Oct 28, 2025
VihasMakwana
force-pushed
the
fix-config-key
branch
from
e672526 to
aa3056c
Compare
VihasMakwana
force-pushed
the
fix-config-key
branch
2 times, most recently
from
310b452 to
6aa0277
Compare
swiatekm
approved these changes
Oct 29, 2025
theletterf
approved these changes
Oct 29, 2025
|
@Mergifyio backport 8.19 9.1 9.2 |
💚 Build Succeeded
History
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
* fix: add flush_interval * couple of enhancements * test samples * lint * use observer and t.Setenv * lint * fix profiling * fix unit test race * more time * comment * enable profiling for linux * Add comment * use DryRun to validate the config --------- Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]> (cherry picked from commit 49af983) # Conflicts: # internal/pkg/otel/samples/linux/profiles_metrics.yml # internal/pkg/otel/samples/windows/managed_otlp/logs_metrics_traces.yml # internal/pkg/otel/samples/windows/managed_otlp/platformlogs.yml # internal/pkg/otel/samples/windows/managed_otlp/platformlogs_hostmetrics.yml
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
* fix: add flush_interval * couple of enhancements * test samples * lint * use observer and t.Setenv * lint * fix profiling * fix unit test race * more time * comment * enable profiling for linux * Add comment * use DryRun to validate the config --------- Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]> (cherry picked from commit 49af983) # Conflicts: # internal/pkg/otel/samples/linux/profiles_metrics.yml # internal/pkg/otel/samples/windows/managed_otlp/logs_metrics_traces.yml # internal/pkg/otel/samples/windows/managed_otlp/platformlogs.yml # internal/pkg/otel/samples/windows/managed_otlp/platformlogs_hostmetrics.yml
This was referenced Oct 29, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
* fix: add flush_interval * couple of enhancements * test samples * lint * use observer and t.Setenv * lint * fix profiling * fix unit test race * more time * comment * enable profiling for linux * Add comment * use DryRun to validate the config --------- Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]> (cherry picked from commit 49af983) # Conflicts: # internal/pkg/otel/samples/windows/managed_otlp/logs_metrics_traces.yml # internal/pkg/otel/samples/windows/managed_otlp/platformlogs.yml # internal/pkg/otel/samples/windows/managed_otlp/platformlogs_hostmetrics.yml
VihasMakwana
added a commit
that referenced
this pull request
Oct 30, 2025
* fix: add flush_interval * couple of enhancements * test samples * lint * use observer and t.Setenv * lint * fix profiling * fix unit test race * more time * comment * enable profiling for linux * Add comment * use DryRun to validate the config --------- Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
VihasMakwana
added a commit
that referenced
this pull request
Oct 30, 2025
* fix: add flush_interval * couple of enhancements * test samples * lint * use observer and t.Setenv * lint * fix profiling * fix unit test race * more time * comment * enable profiling for linux * Add comment * use DryRun to validate the config --------- Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
VihasMakwana
added a commit
that referenced
this pull request
Oct 30, 2025
* fix: add flush_interval * couple of enhancements * test samples * lint * use observer and t.Setenv * lint * fix profiling * fix unit test race * more time * comment * enable profiling for linux * Add comment * use DryRun to validate the config --------- Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
VihasMakwana
added a commit
that referenced
this pull request
Oct 31, 2025
…ws (#10855) * [EDOT][windows] add missing samples for windows (#10728) * add docs and changelog * remove redundant (cherry picked from commit 03a81c0) * add flush_timeout * [samples] remove unneeded file_storage and fix a bug (#10856) * fix: add flush_interval * couple of enhancements * test samples * lint * use observer and t.Setenv * lint * fix profiling * fix unit test race * more time * comment * enable profiling for linux * Add comment * use DryRun to validate the config --------- Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]> --------- Co-authored-by: Vihas Makwana <[email protected]> Co-authored-by: Vihas <[email protected]> Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the
file_storageas it's not used anywhere and useflush_timeout.Also added unit test cases to validate the samples using
DryRun.