Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 8.x] Increase url.query ignore_above value to 2083 (#2424) #2427

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Jan 20, 2025

Increasing the url.query ignore_above value will allow indexing longer query values which have been observed.

2083 is used because it will cover the maximum url length for Chrome (2048) and Internet Explorer (2083).

Other browsers and web servers support longer URLs, and there is no absolute URL limit defined in any RFC. So higher values could be possible, supporting Chrome's maximum length will allow compatibility with the most common browser, while not increasing the index size too much.

  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? y
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. n/a
  • Have you added an entry to the CHANGELOG.next.md? y

Increasing the url.query ignore_above value will allow indexing longer query values which have been observed.

2083 is used because it will cover the maximum url length for Chrome (2048) and Internet Explorer (2083).

Other browsers and web servers support longer URLs, and there is no absolute URL limit defined in any RFC. So higher values could be possible, supporting Chrome's maximum length will allow compatibility with the most common browser, while not increasing the index size too much.
@mjwolf mjwolf requested a review from a team as a code owner January 20, 2025 19:29
Copy link

@qcorporation qcorporation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks

@mjwolf mjwolf merged commit f4acdb7 into elastic:8.x Jan 21, 2025
3 checks passed
@mjwolf mjwolf deleted the backport-2424 branch January 21, 2025 18:05
@mjwolf mjwolf changed the title Increase url.query ignore_above value to 2083 (#2424) [Backport 8.x] Increase url.query ignore_above value to 2083 (#2424) Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants