-
Notifications
You must be signed in to change notification settings - Fork 342
Update clients docs to use 8.19 branch #3216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pquentin I think we need to update at least some of the java client entries, but tbh I'm not super sure about all of them: Lines 1057 to 1082 in 5cb7ead
|
@leemthompo Not sure either, I don't think we care anymore about elasticsearch/client or elasticsearch/docs/java-rest. @swallez @l-trotta any idea? |
The build error FYI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like both the Python and Rust clients need to be updated in this file. The Perl client is still using 8.x
and the rest seem to have never made it to v8.
Edit: A quick way to check is to just go to https://github.com/elastic/{repo}/tree/8.x
and see if it redirects to 8.19
(for example https://github.com/elastic/elasticsearch-rs/tree/8.x).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is lookin' good so far!
Attempts to fix broken build
@pquentin pointed to this list of repos that renamed 8.x to 8.19: https://github.com/elastic/devtools-team/blob/main/.github/workflows/scripts/clients.config