Build 8.x from latest (8.18) #3209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
colleenmcginnis
commented
Apr 17, 2025
colleenmcginnis
commented
Apr 17, 2025
colleenmcginnis
commented
Apr 18, 2025
| @@ -77,7 +77,7 @@ sub check_source { | |||
| next unless $fragment; | |||
| unless ( $self->_fragment_exists( $dest, $path, $fragment ) ) { | |||
| # Check if the path contains 'main' or 'master' | |||
| if ($path =~ /main|master/) { | |||
| if ($path =~ /main|master|8.x/) { | |||
There was a problem hiding this comment.
I had to skip link checking on 8.x branches because it was making the build fail even though the links it fails on do actually exist. 🤷
INFO:build_docs:Bad cross-document links:
--
| INFO:build_docs: /tmp/docsbuild/target_repo/html/en/elasticsearch/reference/8.18/es-connectors-tutorial-api.html contains broken links to:
| INFO:build_docs: - en/elasticsearch/reference/8.x/create-connector-api.html
| INFO:build_docs: - en/kibana/8.x/console-kibana.html
| INFO:build_docs: /tmp/docsbuild/target_repo/html/en/elasticsearch/reference/current/es-connectors-tutorial-api.html contains broken links to:
| INFO:build_docs: - en/elasticsearch/reference/8.x/create-connector-api.html
| INFO:build_docs: - en/kibana/8.x/console-kibana.html
colleenmcginnis
changed the title
|
Closing for now. We can reopen this if we decide we need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try building 8.x the same way we build current.