Skip to content

Enable ESQL qa resources for the main branch #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

ChrisHegarty
Copy link
Contributor

This commit enables the x-pack/plugin/esql/qa/testFixtures/src/main/resources resource for building the Elasticsearch main branch. The directory contains files that are used for code snippet testing.

This will be required for once ESQL merges into main, post 8.10, see elastic/elasticsearch#98309.

relates #2732

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty changed the title Enable ESQL sq resource for the main branch Enable ESQL resources for the main branch Aug 14, 2023
@ChrisHegarty ChrisHegarty changed the title Enable ESQL resources for the main branch Enable ESQL qa resources for the main branch Aug 14, 2023
@ChrisHegarty
Copy link
Contributor Author

The CI currently fails with:

INFO:build_docs:fatal: pathspec 'x-pack/plugin/esql/qa/testFixtures/src/main/resources' did not match any files

, which is expected until after ESQL merges into main. After which this change will be merged.

@abdonpijpelink abdonpijpelink merged commit 01d23ef into elastic:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants