Skip to content

Commit 0b0fc4f

Browse files
committed
test: skip [email protected] in TAV tests to workaround npm v6 install issue with github deps
[email protected] (and only that version) has a github dep: "@types/mysql": "types/mysql", Attempting to install that version with npm v6 (the npm in node v10, v12, and v14) hits npm/cli#4896 which results in an install so slow that is hits the default 2 minute 'npm install' timeout in the `tav` tool.
1 parent 112a13c commit 0b0fc4f

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

.tav.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ mysql:
3232
commands:
3333
- node test/instrumentation/modules/mysql/mysql.test.js
3434
- node test/instrumentation/modules/mysql/pool-release-1.test.js
35+
36+
# mysql2
37+
# - v1.6.2 is broken: https://github.com/sidorares/node-mysql2/issues/869
38+
# - v2.2.3 has a github dep ("@types/mysql": "types/mysql") that hits
39+
# npm v6 install issue https://github.com/npm/cli/issues/4896
3540
mysql2-old:
3641
name: mysql2
3742
versions: '>=1.0.0 <1.6.0'
@@ -40,11 +45,12 @@ mysql2-old:
4045
- node test/instrumentation/modules/mysql2/pool-release-1.test.js
4146
mysql2-new:
4247
name: mysql2
43-
versions: '1.6.0 || 1.6.1 || >=1.6.3 <3' # v1.6.2 is broken: https://github.com/sidorares/node-mysql2/issues/869
48+
versions: '>=1.6.0 <1.6.2 || >=1.6.3 <2.2.3 || >=2.2.4 <3'
4449
node: '>=6.0.0'
4550
commands:
4651
- node test/instrumentation/modules/mysql2/mysql.test.js
4752
- node test/instrumentation/modules/mysql2/pool-release-1.test.js
53+
4854
redis:
4955
versions: '>=2.0.0 <4.0.0'
5056
commands: node test/instrumentation/modules/redis.test.js

0 commit comments

Comments
 (0)