test: fix running benchmarks (#2693)

trentm · web-flow · commit 112a13c333a3 · 2022-05-13T09:58:43.000-07:00
The change away from `NODE_VERSION` in #2627 surprisingly broke running the benchmarks. `NODE_VERSION` is used by nvm and exporting it (?) makes a difference?
diff --git a/.ci/Jenkinsfile b/.ci/Jenkinsfile
@@ -383,7 +383,7 @@ pipeline {
       environment {
         HOME = "${env.WORKSPACE}"
         RESULT_FILE = 'apm-agent-benchmark-results.json'
-        BENCH_NODE_VERSION = '14'
+        NODE_VERSION = '14'
       }
       when {
         beforeAgent true
@@ -402,7 +402,7 @@ pipeline {
             deleteDir()
             unstash 'source'
             dir(BASE_DIR){
-              sh '.ci/scripts/run-benchmarks.sh "${RESULT_FILE}" "${BENCH_NODE_VERSION}"'
+              sh '.ci/scripts/run-benchmarks.sh "${RESULT_FILE}" "${NODE_VERSION}"'
             }
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ pipeline {`
`383`	`383`	`environment {`
`384`	`384`	`HOME = "${env.WORKSPACE}"`
`385`	`385`	`RESULT_FILE = 'apm-agent-benchmark-results.json'`
`386`		`- BENCH_NODE_VERSION = '14'`
	`386`	`+ NODE_VERSION = '14'`
`387`	`387`	`}`
`388`	`388`	`when {`
`389`	`389`	`beforeAgent true`
`@@ -402,7 +402,7 @@ pipeline {`
`402`	`402`	`deleteDir()`
`403`	`403`	`unstash 'source'`
`404`	`404`	`dir(BASE_DIR){`
`405`		`- sh '.ci/scripts/run-benchmarks.sh "${RESULT_FILE}" "${BENCH_NODE_VERSION}"'`
	`405`	`+ sh '.ci/scripts/run-benchmarks.sh "${RESULT_FILE}" "${NODE_VERSION}"'`
`406`	`406`	`}`
`407`	`407`	`}`
`408`	`408`	`}`