Skip to content

Conversation

@miguelslemos
Copy link

@miguelslemos miguelslemos commented Oct 29, 2025

  • Add resources S3vectorsBucket, S3vectorsIndex and S3vectorsVector
  • Add tests
  • Add docs
us-east-1 - S3vectorsIndex - my-vector-index - [BucketName: "my-s3-bucket-vectors-mig", IndexARN: "arn:aws:s3vectors:us-east-1:X:bucket/my-s3-bucket-vectors-mig/index/my-vector-index", IndexName: "my-vector-index"] - would remove after dependencies
us-east-1 - S3vectorsVector - document-1 - [IndexName: "my-vector-index", Key: "document-1", VectorBucketName: "my-s3-bucket-vectors-mig"] - would remove
us-east-1 - S3vectorsBucket - my-s3-bucket-vectors-mig - [ARN: "arn:aws:s3vectors:us-east-1:X:bucket/my-s3-bucket-vectors-mig", Name: "my-s3-bucket-vectors-mig"] - would remove after dependencies

fixes: #777

@miguelslemos miguelslemos changed the title Add support for s3vectors resources feat: add support for s3vectors resources Oct 29, 2025
@miguelslemos miguelslemos force-pushed the add-resource-s3-vectors branch from c7f8113 to 75225f7 Compare October 29, 2025 14:50
@miguelslemos miguelslemos force-pushed the add-resource-s3-vectors branch from 75225f7 to f43a11e Compare October 29, 2025 19:39
@ekristen
Copy link
Owner

Thanks for the contribution. The only thing I think I'm on the fence about is if it should be S3vector or S3Vector I think I want the capitalized V as it aligns with how all other resources are named.

Resource: &S3VectorsBucket{},
Lister: &S3VectorsBucketLister{},
DependsOn: []string{
S3VectorsIndexResource,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the hierarchy implemented:
S3VectorsBucket depends on S3VectorsIndex, which depends on S3VectorsVector.

Is it possible for an S3VectorsVector to exist without an S3VectorsIndex?
If so, the Bucket should also depend on it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also say that the dependency hierarchy is definitely experimental and a bit buggy, it can cause some stalled removes. Love that you are using it, or might be, would appreciate any feedback to issues you encounter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3Vectors support

4 participants