Skip to content

feat: add configuration flag to support maximum retries on resource failure #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add configuration flag to support maximum retries on resource failure #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions pkg/commands/nuke/nuke.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,15 @@

// Create the parameters object that will be used to configure the nuke process.
params := &libnuke.Parameters{
Force: c.Bool("force"),
ForceSleep: c.Int("force-sleep"),
Quiet: c.Bool("quiet"),
NoDryRun: c.Bool("no-dry-run"),
Includes: c.StringSlice("include"),
Excludes: c.StringSlice("exclude"),
Alternatives: c.StringSlice("cloud-control"),
MaxWaitRetries: c.Int("max-wait-retries"),
Force: c.Bool("force"),
ForceSleep: c.Int("force-sleep"),
Quiet: c.Bool("quiet"),
NoDryRun: c.Bool("no-dry-run"),
Includes: c.StringSlice("include"),
Excludes: c.StringSlice("exclude"),
Alternatives: c.StringSlice("cloud-control"),
MaxWaitRetries: c.Int("max-wait-retries"),
MaxFailureRetries: c.Int("max-failure-retries"),

Check failure on line 68 in pkg/commands/nuke/nuke.go

View workflow job for this annotation

GitHub Actions / test 

unknown field MaxFailureRetries in struct literal of type "github.com/ekristen/libnuke/pkg/nuke".Parameters

Check failure on line 68 in pkg/commands/nuke/nuke.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

unknown field MaxFailureRetries in struct literal of type "github.com/ekristen/libnuke/pkg/nuke".Parameters (typecheck)
}

if len(c.StringSlice("feature-flag")) > 0 {
Expand Down Expand Up @@ -296,6 +297,11 @@
Usage: "maximum number of retries to wait for dependencies to be removed",
Action: common.CheckRealInt,
},
&cli.IntFlag{
Name: "max-failure-retries",
Usage: "maximum number of retries to wait for failed dependencies to be removed",
Action: common.CheckRealInt,
},
&cli.DurationFlag{
Name: "run-sleep-delay",
Sources: cli.EnvVars("AWS_NUKE_RUN_SLEEP_DELAY"),
Expand Down
Loading