Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Mark post as read when opening from media previews #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rcbadiale
Copy link

Description

Updates the behavior from the media previews (image and multimedia) to set the post as read when opened by taping them.

Changes Made

  • Modified the EmbeddedMultiMediaView to receive an onTap callback and call it when tapped;
  • Modified the MediaView to receive an onTap callback and:
    • call it when the type is image;
    • pass it along to the EmbeddedMultiMediaView
  • Modified the PostFeedView to pass the PostUtils.shared.markRead to the previews to be called on tap;

Expected behavior

Given the user is on the feed view (home, all, favorites, subreddit, ...)
And there are posts with previews (image, video, url)
When the user tap the preview
Then the preview should load the image/video/url
When going back to the feed
Then the post should be marked as read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant