fix: prevent stack overflow when collecting comments #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the generator will panic due to stack overflow when generating from a proto descriptor with cycles. For example `google.protobuf.Struct` contains such loops. This commit fixes this issue by: * Collecting comments for top level messages * When encountering the same message again, exit early
ericwenn
force-pushed
the
stack-overflow-comments
branch
from
979d03a to
a6e59e3
Compare
alethenorio
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generator will panic due to stack overflow when generating
from a proto descriptor with cycles. For example
google.protobuf.Structcontains such loops.This commit fixes this issue by: