Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use require in ESM, use dynamic import #205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't use require in ESM, use dynamic import #205

wants to merge 2 commits into from

Conversation

segevfiner
Copy link

Fixes #168

@talkor
Copy link

talkor commented Aug 30, 2022

Thank you for this!

@edenhermelin
Copy link

@segevfiner thank you so much for this, it helps us a lot!
@egoist - looks like the CI build fails for linter (on the dynamic import). Any chance you can look into it please? this fix will make this library be usable by Vite 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with Vite
3 participants
@segevfiner @talkor @edenhermelin