-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: implement changesets for selective package versioning #5691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
Co-authored-by: fengmk2 <[email protected]>
Deploying egg-v3 with
|
| Latest commit: |
f42437f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f21dab1.egg-v3.pages.dev |
| Branch Preview URL: | https://copilot-use-changesets-for-v.egg-v3.pages.dev |
Deploying egg with
|
| Latest commit: |
f42437f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1405e82a.egg-cci.pages.dev |
| Branch Preview URL: | https://copilot-use-changesets-for-v.egg-cci.pages.dev |
Co-authored-by: fengmk2 <[email protected]>
| - name: Create Release Pull Request or Publish | ||
| id: changesets | ||
| uses: changesets/action@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step: changesets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot pinned commit hash
Co-authored-by: fengmk2 <[email protected]>
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5691 +/- ##
==========================================
+ Coverage 85.40% 85.43% +0.02%
==========================================
Files 561 561
Lines 10931 10931
Branches 1238 1238
==========================================
+ Hits 9336 9339 +3
+ Misses 1496 1493 -3
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "types": "./dist/index.d.ts" | ||
| "main": "./dist/index.mjs", | ||
| "module": "./dist/index.mjs", | ||
| "types": "./dist/index.d.mts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot don't change the file name extension, for all!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted all package.json files to their original state. The file extension changes (.js to .mjs, .d.ts to .d.mts) were unintended side effects from pnpm install and have been removed. Fixed in f42437f.
Co-authored-by: fengmk2 <[email protected]>
Co-authored-by: fengmk2 <[email protected]>
Implement Changesets for Version Management ✅
Successfully implemented changesets for version management in the Egg.js monorepo, addressing the issue request to avoid bulk releases of all packages.
✅ All Tasks Completed
📦 What Was Changed
1. Changeset Infrastructure
@changesets/clidependency (catalog managed).changeset/config.jsonfor the monoreponext, Access:public2. NPM Scripts (package.json)
3. GitHub Actions Workflow
.github/workflows/changesets.ymlautomates releasesnext4. Documentation
docs/changeset-guide.md(English, 5KB)docs/changeset-guide.zh-CN.md(Chinese, 4.5KB)5. Workspace Configuration
pnpm-workspace.yamlto exclude problematic packages fromminimumReleaseAge@changesets/*,rolldown-plugin-dts,obug,unrun🎯 Key Benefits
✅ Selective Publishing: Only changed packages are versioned and published
✅ Automatic Changelogs: Generated from changeset summaries per package
✅ Better Tracking: Clear documentation of what changed and why
✅ PR-Based Workflow: Review version changes before publishing
✅ Backward Compatible: Old
scripts/version.jsremains for compatibility✅ Bilingual Documentation: Complete guides in English and Chinese
✅ Secure Publishing: Uses npm trusted publishing with provenance
🔄 How It Works
pnpm changesetnextbranch triggers GitHub Actions🚀 Migration Strategy
The old version scripts (
scripts/version.js) are kept for:Going forward, changesets should be the primary method for version management.
✅ Quality Checks
📚 References
This PR implements the complete changeset infrastructure. The workflow will be fully functional once merged to the
nextbranch.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.