remove colon from accounts, modes #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine, but please add // TODO comments because we don't want to leave it like this long-term. I disagree with all of this and think inspircd should be fixed, not eggdrop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: @Robby-
Patch by: Geo
One-line summary:
Remove colons from trailing IRC command
Additional description (if needed):
Inspircd v3 started putting :'s on all trailing commands, even if they cannot have a space in them (accounts, nicks, etc). This broke how Eggdrop stored account names sent from WHOX, and nicknames contained in MODE commands.
This is a blunt-force and inelegant patch but it at least fixes the identified issues... there are probably more messages that are needed to be handled but not known at this time, and maybe a larger code revamp could be done. Just not today.
https://docs.inspircd.org/faq/#why-does-my-client-not-show-mode-changesopped-users-on-joinetc-correctly-when-using-inspircd-v3