simple_sprintf() -> snprintf() and fix format specifier / datatype for time_t #1775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
simple_sprintf()
->snprintf()
and fix format specifier / datatype fortime_t
Additional description (if needed):
See also:
eggdrop/src/botmsg.c
Lines 138 to 141 in 541e8ac
eggdrops
simple_sprintf()
brings a%D
specifier for converting int to base64. Those are harder to migrate tosnprintf()
. But all others should be migrated over time. One benefit is indeed that the compiler will be able to do more checks.Test cases demonstrating functionality (if applicable):