Skip to content

[codex] Increase AdMob revenue surfaces #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
John Dlugokecki (jdlugo) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] Increase AdMob revenue surfaces #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions Cronica.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,14 @@
B8FCAE892AED8C9300F688FE /* WatchlistSearchScope.swift in Sources */ = {isa = PBXBuildFile; fileRef = B8389ED128AB46E3003025BC /* WatchlistSearchScope.swift */; };
B8FCAE8A2AED8CA200F688FE /* FilmographyListView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B8C781F1287F576100B4C2C2 /* FilmographyListView.swift */; };
B8FCAE922AED9CE300F688FE /* CronicaTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = B8FCAE912AED9CE300F688FE /* CronicaTests.swift */; };
CDAD00010000000000000001 /* AdConfiguration.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDAD00100000000000000001 /* AdConfiguration.swift */; platformFilter = ios; };
CDAD00020000000000000001 /* AdConsentManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDAD00110000000000000001 /* AdConsentManager.swift */; platformFilter = ios; };
CDAD00030000000000000001 /* AdCoordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDAD00120000000000000001 /* AdCoordinator.swift */; platformFilter = ios; };
CDAD00040000000000000001 /* AdmobSwiftUI in Frameworks */ = {isa = PBXBuildFile; platformFilter = ios; productRef = CDAD00300000000000000001 /* AdmobSwiftUI */; };
CDAD00050000000000000001 /* AdConfigurationTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDAD00200000000000000001 /* AdConfigurationTests.swift */; };
CDAD00060000000000000001 /* AdCoordinatorTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDAD00210000000000000001 /* AdCoordinatorTests.swift */; };
CDAD00070000000000000001 /* AdGatingTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDAD00220000000000000001 /* AdGatingTests.swift */; };
CDAD00080000000000000001 /* AdStartupCoordinatorTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = CDAD00230000000000000001 /* AdStartupCoordinatorTests.swift */; };
B8FCAE982AEDA38E00F688FE /* SeasonListView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B8FF4DBA27F91A4900C7DE9F /* SeasonListView.swift */; };
B8FF4DBB27F91A4900C7DE9F /* SeasonListView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B8FF4DBA27F91A4900C7DE9F /* SeasonListView.swift */; };
B8FF4DBF27FA511A00C7DE9F /* TitleView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B8FF4DBE27FA511A00C7DE9F /* TitleView.swift */; };
Expand Down Expand Up @@ -646,6 +654,13 @@
B8FB2A8F295263AB006DAC8E /* AboutSettings.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AboutSettings.swift; sourceTree = "<group>"; };
B8FCAE8F2AED9CE300F688FE /* Cronica Tests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "Cronica Tests.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
B8FCAE912AED9CE300F688FE /* CronicaTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CronicaTests.swift; sourceTree = "<group>"; };
CDAD00100000000000000001 /* AdConfiguration.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdConfiguration.swift; sourceTree = "<group>"; };
CDAD00110000000000000001 /* AdConsentManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdConsentManager.swift; sourceTree = "<group>"; };
CDAD00120000000000000001 /* AdCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdCoordinator.swift; sourceTree = "<group>"; };
CDAD00200000000000000001 /* AdConfigurationTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdConfigurationTests.swift; sourceTree = "<group>"; };
CDAD00210000000000000001 /* AdCoordinatorTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdCoordinatorTests.swift; sourceTree = "<group>"; };
CDAD00220000000000000001 /* AdGatingTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdGatingTests.swift; sourceTree = "<group>"; };
CDAD00230000000000000001 /* AdStartupCoordinatorTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdStartupCoordinatorTests.swift; sourceTree = "<group>"; };
B8FF4DBA27F91A4900C7DE9F /* SeasonListView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SeasonListView.swift; sourceTree = "<group>"; };
B8FF4DBE27FA511A00C7DE9F /* TitleView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TitleView.swift; sourceTree = "<group>"; };
B8FF4DC027FB56F500C7DE9F /* SFSafariViewWrapper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SFSafariViewWrapper.swift; sourceTree = "<group>"; };
Expand All @@ -670,6 +685,7 @@
B8F367642AF5CAAA0027CAF9 /* Aptabase in Frameworks */,
B86A3A902B509C9B00BDE432 /* Pow in Frameworks */,
B8424FB02C7A01500098BFFB /* YouTubePlayerKit in Frameworks */,
CDAD00040000000000000001 /* AdmobSwiftUI in Frameworks */,
B86A3A8D2B509C8200BDE432 /* NukeUI in Frameworks */,
B86A3A8B2B509C8200BDE432 /* Nuke in Frameworks */,
B87F74642806592E00E94126 /* CloudKit.framework in Frameworks */,
Expand Down Expand Up @@ -1347,6 +1363,9 @@
children = (
B8110F162792764B00844FEB /* Cronica.entitlements */,
B8CC953527D05E4A00B6757C /* Cronica-Info.plist */,
CDAD00100000000000000001 /* AdConfiguration.swift */,
CDAD00110000000000000001 /* AdConsentManager.swift */,
CDAD00120000000000000001 /* AdCoordinator.swift */,
B8110ED8279245D000844FEB /* CronicaApp.swift */,
B86E587827A48E5A005DBF38 /* Key.swift */,
B8E6D64027B6B106002E7A63 /* Watchlist.xcdatamodeld */,
Expand Down Expand Up @@ -1415,6 +1434,10 @@
isa = PBXGroup;
children = (
B8FCAE912AED9CE300F688FE /* CronicaTests.swift */,
CDAD00200000000000000001 /* AdConfigurationTests.swift */,
CDAD00210000000000000001 /* AdCoordinatorTests.swift */,
CDAD00220000000000000001 /* AdGatingTests.swift */,
CDAD00230000000000000001 /* AdStartupCoordinatorTests.swift */,
);
path = CronicaTests;
sourceTree = "<group>";
Expand Down Expand Up @@ -1467,6 +1490,7 @@
B86A3A8C2B509C8200BDE432 /* NukeUI */,
B86A3A8F2B509C9B00BDE432 /* Pow */,
B8424FAF2C7A01500098BFFB /* YouTubePlayerKit */,
CDAD00300000000000000001 /* AdmobSwiftUI */,
);
productName = "Story (iOS)";
productReference = B8110EDF279245D100844FEB /* Cronica.app */;
Expand Down Expand Up @@ -1555,6 +1579,7 @@
B86A3A892B509C8200BDE432 /* XCRemoteSwiftPackageReference "Nuke" */,
B86A3A8E2B509C9B00BDE432 /* XCRemoteSwiftPackageReference "Pow" */,
B8424FAE2C7A01500098BFFB /* XCRemoteSwiftPackageReference "YouTubePlayerKit" */,
CDAD00310000000000000001 /* XCRemoteSwiftPackageReference "AdmobSwiftUI" */,
);
productRefGroup = B8110EE0279245D100844FEB /* Products */;
projectDirPath = "";
Expand Down Expand Up @@ -1756,6 +1781,9 @@
B82BE4F2299EB3F5005F9990 /* WatchlistTitle.swift in Sources */,
B818483729C286C300650763 /* UserDefaults-Extensions.swift in Sources */,
B8110EE8279245D100844FEB /* CronicaApp.swift in Sources */,
CDAD00010000000000000001 /* AdConfiguration.swift in Sources */,
CDAD00020000000000000001 /* AdConsentManager.swift in Sources */,
CDAD00030000000000000001 /* AdCoordinator.swift in Sources */,
B84F022A299026B7007EA8AE /* DatesManager.swift in Sources */,
B8B2F6AA2A85D50A00FF0246 /* SearchItemContent.swift in Sources */,
B81941C82A0861C80057DA04 /* ArchiveButton.swift in Sources */,
Expand Down Expand Up @@ -1971,6 +1999,10 @@
buildActionMask = 2147483647;
files = (
B8FCAE922AED9CE300F688FE /* CronicaTests.swift in Sources */,
CDAD00050000000000000001 /* AdConfigurationTests.swift in Sources */,
CDAD00060000000000000001 /* AdCoordinatorTests.swift in Sources */,
CDAD00070000000000000001 /* AdGatingTests.swift in Sources */,
CDAD00080000000000000001 /* AdStartupCoordinatorTests.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -2506,6 +2538,14 @@
minimumVersion = 0.3.4;
};
};
CDAD00310000000000000001 /* XCRemoteSwiftPackageReference "AdmobSwiftUI" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/dearhui/AdmobSwiftUI.git";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 2.0.0;
};
};
/* End XCRemoteSwiftPackageReference section */

/* Begin XCSwiftPackageProductDependency section */
Expand Down Expand Up @@ -2554,6 +2594,11 @@
package = B8F367622AF5CA900027CAF9 /* XCRemoteSwiftPackageReference "aptabase-swift" */;
productName = Aptabase;
};
CDAD00300000000000000001 /* AdmobSwiftUI */ = {
isa = XCSwiftPackageProductDependency;
package = CDAD00310000000000000001 /* XCRemoteSwiftPackageReference "AdmobSwiftUI" */;
productName = AdmobSwiftUI;
};
/* End XCSwiftPackageProductDependency section */

/* Begin XCVersionGroup section */
Expand Down
29 changes: 28 additions & 1 deletion Cronica.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

107 changes: 107 additions & 0 deletions CronicaTests/AdConfigurationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
import XCTest
@testable import Cronica

final class AdConfigurationTests: XCTestCase {

// MARK: - Ad Unit ID Format

func testNativeAdUnitIDHasCorrectPrefix() {
XCTAssertTrue(
AdConfiguration.AdUnitID.native.hasPrefix("ca-app-pub-"),
"Native ad unit ID must start with 'ca-app-pub-'"
)
}

func testInterstitialAdUnitIDHasCorrectPrefix() {
XCTAssertTrue(
AdConfiguration.AdUnitID.interstitial.hasPrefix("ca-app-pub-"),
"Interstitial ad unit ID must start with 'ca-app-pub-'"
)
}

func testRewardedAdUnitIDHasCorrectPrefix() {
XCTAssertTrue(
AdConfiguration.AdUnitID.rewarded.hasPrefix("ca-app-pub-"),
"Rewarded ad unit ID must start with 'ca-app-pub-'"
)
}

func testAppOpenAdUnitIDHasCorrectPrefix() {
XCTAssertTrue(
AdConfiguration.AdUnitID.appOpen.hasPrefix("ca-app-pub-"),
"App open ad unit ID must start with 'ca-app-pub-'"
)
}

func testAdUnitIDsAreNotEmpty() {
XCTAssertFalse(AdConfiguration.AdUnitID.native.isEmpty)
XCTAssertFalse(AdConfiguration.AdUnitID.interstitial.isEmpty)
XCTAssertFalse(AdConfiguration.AdUnitID.rewarded.isEmpty)
XCTAssertFalse(AdConfiguration.AdUnitID.appOpen.isEmpty)
}

func testAdUnitIDsAreDifferent() {
let ids = [
AdConfiguration.AdUnitID.native,
AdConfiguration.AdUnitID.interstitial,
AdConfiguration.AdUnitID.rewarded,
AdConfiguration.AdUnitID.appOpen,
]

XCTAssertEqual(
Set(ids).count,
ids.count,
"All ad placements must use distinct ad unit IDs"
)
}

func testAdUnitIDsAreNotGoogleTestIDs() {
// Google's well-known test ad unit IDs
let testIDs = [
"ca-app-pub-3940256099942544/2934735716", // test banner
"ca-app-pub-3940256099942544/4411468910", // test interstitial
"ca-app-pub-3940256099942544/1712485313", // test rewarded
"ca-app-pub-3940256099942544/3986624511", // test native
"ca-app-pub-3940256099942544/6300978111", // test app open
]
XCTAssertFalse(testIDs.contains(AdConfiguration.AdUnitID.native),
"Production build must not use Google test ad unit IDs")
XCTAssertFalse(testIDs.contains(AdConfiguration.AdUnitID.interstitial),
"Production build must not use Google test ad unit IDs")
XCTAssertFalse(testIDs.contains(AdConfiguration.AdUnitID.rewarded),
"Production build must not use Google test ad unit IDs")
XCTAssertFalse(testIDs.contains(AdConfiguration.AdUnitID.appOpen),
"Production build must not use Google test ad unit IDs")
}

// MARK: - Policy Compliance

func testNativeRefreshIntervalMeetsGoogleMinimum() {
// Google AdMob policy: minimum 30 seconds between native ad refreshes
XCTAssertGreaterThanOrEqual(
AdConfiguration.nativeRefreshInterval, 30,
"Native ad refresh interval must be >= 30s per Google policy"
)
}

func testInterstitialCooldownAllowsImmediateRepeatPresentation() {
XCTAssertEqual(
AdConfiguration.interstitialCooldown, 0,
"Interstitial cooldown should be disabled so repeat eligible actions can monetize immediately"
)
}

func testAppOpenCooldownAllowsImmediateForegroundPresentation() {
XCTAssertEqual(
AdConfiguration.appOpenCooldown, 0,
"App open cooldown should be disabled so foreground returns can monetize immediately"
)
}

func testNativeInitialRequestDelayDoesNotThrottleStartupRequests() {
XCTAssertEqual(
AdConfiguration.nativeInitialRequestDelay, 0,
"Native request startup delay should be disabled so monetized screens request immediately"
)
}
}
Loading