Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More filesystem benchmarks #802

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

More filesystem benchmarks #802

wants to merge 7 commits into from

Conversation

phischu
Copy link
Collaborator

@phischu phischu commented Jan 24, 2025

@marvinborner I would like these and the other benchmarks in input_output integrated into effekt plots.

def run(n: Int) = {
with on[IOError].panic;

val filename = "/tmp/financial_information_exchange.txt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be problematic when run in parallel by the different backend tests, like before.

@marvinborner
Copy link
Member

marvinborner commented Jan 27, 2025

The current setup runs every benchmark that's listed in benchmarks/config_${BACKEND}.txt with their respective argument. Since the IO benchmarks don't use a configurable argument, we can just add the filename without it -- the benchmark will be run regardless.

We can add the lines in this PR, do we want to run them for JS and LLVM?

(edit: I've since realized that IO benchmarks also use arguments)

@phischu phischu force-pushed the benchmark_files branch 2 times, most recently from e42703c to 0bbeaa6 Compare February 6, 2025 19:59
@phischu
Copy link
Collaborator Author

phischu commented Feb 6, 2025

For larger input sizes many of these segfault on the llvm backend. I am wondering why...

@phischu phischu force-pushed the benchmark_files branch 3 times, most recently from ba088cf to de730a8 Compare February 13, 2025 11:22
@phischu
Copy link
Collaborator Author

phischu commented Feb 13, 2025

I figured it out: classical buffer overflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants