Make pretty-printed core more readable #1237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsueberkrueb
force-pushed
the
improve-core-pretty
branch
from
490bc66 to
6fb4be9
Compare
timsueberkrueb
commented
Dec 1, 2025
| // For many purposes, we would like to include the user-annotated name in the fresh id, | ||
| // so that printed terms are more readable. | ||
| // However, we do not want to include it when checking for alpha-equivalence in tests. | ||
| val userPart = if preserveUserAnnotatedPrefix then userName else "" |
Contributor
Author
There was a problem hiding this comment.
We can probably get rid of this by moving the userName logic to idFor. We need to be careful with this, though, as idFor is also used by core.Parser.
timsueberkrueb
force-pushed
the
improve-core-pretty
branch
from
c21c0d7 to
121d6b8
Compare
timsueberkrueb
changed the title
timsueberkrueb
commented
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1181 we made the core pretty printer a lot more verbose in order to enable re-parsing. However, the additional verbosity hinders human inspection and debugging. This PR aims to mitigate this by splitting the core pretty printer in two instances:
ReparsablePrettyPrinteris fully verbose and can be re-parsed withcore.ParserHumanReadablePrettyPrinteris less verbose (and thus more readable) but cannot be re-parsed