Skip to content

Commit

Permalink
Merge pull request #38 from NullVoxPopuli/prettier
Browse files Browse the repository at this point in the history
Prettier
  • Loading branch information
ef4 authored Oct 23, 2024
2 parents 27c302f + 1e00f76 commit 61207bc
Show file tree
Hide file tree
Showing 17 changed files with 352 additions and 327 deletions.
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*.yaml
*.yml
*.md
3 changes: 3 additions & 0 deletions .prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
singleQuote: true,
};
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"editor.formatOnSave": true
}
}
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ Example Config:
{
plugins: [
[
"decorator-transforms",
'decorator-transforms',
{
runtime: {
import: require.resolve("decorator-transforms/runtime"),
import: require.resolve('decorator-transforms/runtime'),
},
},
],
Expand Down Expand Up @@ -89,7 +89,7 @@ If you try to use the string name "decorator-transforms" in a babel config file,
3. At the beginning of `app.js`, install the global runtime helpers:
```js
import "decorator-transforms/globals";
import 'decorator-transforms/globals';
```
In classic builds, `"globals"` is the only `runtime` setting that works because ember-auto-import cannot see the output of this babel transform.
Expand Down
16 changes: 8 additions & 8 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@ Releases in this repo are mostly automated using [release-plan](https://github.c

## Preparation

Since the majority of the actual release process is automated, the remaining tasks before releasing are:
Since the majority of the actual release process is automated, the remaining tasks before releasing are:

- correctly labeling **all** pull requests that have been merged since the last release
- updating pull request titles so they make sense to our users
- correctly labeling **all** pull requests that have been merged since the last release
- updating pull request titles so they make sense to our users

Some great information on why this is important can be found at [keepachangelog.com](https://keepachangelog.com/en/1.1.0/), but the overall
guiding principle here is that changelogs are for humans, not machines.

When reviewing merged PR's the labels to be used are:

* breaking - Used when the PR is considered a breaking change.
* enhancement - Used when the PR adds a new feature or enhancement.
* bug - Used when the PR fixes a bug included in a previous release.
* documentation - Used when the PR adds or updates documentation.
* internal - Internal changes or things that don't fit in any other category.
- breaking - Used when the PR is considered a breaking change.
- enhancement - Used when the PR adds a new feature or enhancement.
- bug - Used when the PR fixes a bug included in a previous release.
- documentation - Used when the PR adds or updates documentation.
- internal - Internal changes or things that don't fit in any other category.

**Note:** `release-plan` requires that **all** PRs are labeled. If a PR doesn't fit in a category it's fine to label it as `internal`

Expand Down
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
],
"scripts": {
"build": "tsup --dts",
"lint": "tsc",
"lint": "tsc && prettier --check .",
"lint:fix": "prettier --write .",
"start": "tsup --dts --watch",
"test": "node --experimental-vm-modules node_modules/qunit/bin/qunit.js --require @swc-node/register tests/*-test.ts",
"typecheck": "tsc",
Expand All @@ -46,12 +47,13 @@
"@babel/plugin-proposal-decorators": "^7.23.3",
"@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-private-methods": "^7.23.3",
"@embroider/shared-internals": "^2.5.1",
"@babel/preset-env": "^7.24.4",
"@embroider/shared-internals": "^2.5.1",
"@swc-node/register": "^1.6.8",
"@types/babel__core": "^7.20.4",
"@types/node": "^20.9.1",
"@types/qunit": "^2.19.8",
"prettier": "^3.3.3",
"qunit": "^2.20.0",
"release-plan": "^0.9.0",
"tsup": "^7.3.0",
Expand Down
59 changes: 36 additions & 23 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/globals.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import * as runtime from "./runtime.ts";
import { globalId } from "./global-id.ts";
import * as runtime from './runtime.ts';
import { globalId } from './global-id.ts';
(globalThis as any)[globalId] = runtime;
Loading

0 comments on commit 61207bc

Please sign in to comment.