Fix temporary files recognition #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue connected with temporary files recognition during auto-completion process. Invoking the “find definition” facility on a symbol placed in the file currently being edited implied opening a temporary file (with a `.racertmp` infix), which does not seem to exist at the moment immediately after executing a Racer command. The RacerClient class imports `temp` and performs a `temp.open()` call for creating, opening and writing a temporary file passed into Racer. The `temp` library uses `Math.random` and `toString(36)` in order to produce a random path suffix. When called on a floating-point number, the `toString` method generate a string containing a decimal delimeter (`.`). Hence that random path suffix contains an extra dot (e.g. `._main.rs.racertmp116717-2079-43y0eh.hktltbj4i`), and `extname` yields some random noise (`.hktltbj4i` in the previous example) instead of a string starting with `.racertmp`. That was not correctly handled by the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue connected with temporary files recognition
during auto-completion process. Invoking the “find definition” facility
on a symbol placed in the file currently being edited implied opening
a temporary file (with a
.racertmpinfix), which does not seem to existat the moment immediately after executing a Racer command.
The RacerClient class imports
tempand performs atemp.open()callfor creating, opening and writing a temporary file passed into Racer.
The
templibrary usesMath.randomandtoString(36)in order toproduce a random path suffix. When called on a floating-point number,
the
toStringmethod generate a string containing a decimal delimeter(
.). Hence that random path suffix contains an extra dot(e.g.
._main.rs.racertmp116717-2079-43y0eh.hktltbj4i), andextnameyields some random noise (
.hktltbj4iin the previous example) insteadof a string starting with
.racertmp. That was not correctly handledby the code.
The attached screenshot illustrates what happened on my machine
before applying the patch.