Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable virtualWorkspaces with reason why #311

Merged
merged 2 commits into from
Aug 13, 2021
Merged

disable virtualWorkspaces with reason why #311

merged 2 commits into from
Aug 13, 2021

Conversation

nrayburn-tech
Copy link

Virtual workspaces cannot be used because editorconfig requires file system access through node's fs. There was also 1 or 2 other places in the code that were questionable as to whether they could be converted to support virtual workspaces or not.

fixes #306

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run compile).
  • Run npm run lint w/o errors.

@nrayburn-tech nrayburn-tech merged commit 9574c4c into editorconfig:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support virtual workspaces
2 participants