Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added leading slash tests #59

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

mipo256
Copy link
Member

@mipo256 mipo256 commented Feb 23, 2025

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks fine with a few grammar fixes. What do you think, @cxw42 ?

@mipo256
Copy link
Member Author

mipo256 commented Feb 24, 2025

Hey @xuhdev!
I've resolved all the comments, can you please re-review now?

@mipo256 mipo256 requested a review from xuhdev February 24, 2025 07:01
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can merge this once editorconfig/specification#68 is merged.

@xuhdev
Copy link
Member

xuhdev commented Feb 24, 2025

Actually I'm gonna merge this now because this is what's expected now. editorconfig/specification#68 just clarifies in the spec.

@xuhdev xuhdev merged commit 38e1f14 into editorconfig:master Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants