Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce StreamProvider #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kounoike
Copy link

Hi! I'm GitBucket developer. GitBucket is open source Git platform powered by Scala. It looks like as GitHub. It has online git repository browser and online file editor.

I was interested in making GitBucket correspond to Editorconfig. But, current implementation is based on local filesystem's file. So I introduced StreamProvider by this PR. I also wrote JGitProvider in my branch of GitBucket. see here

If this PR is merged and it released to maven, I can make EditorConfig support PR to GitBucket.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 21, 2018

Hi @kounoike , in case you look around and decide this project is not lively enough, you may want to look at the alternative Java editorconfig parser called https://github.com/ec4j/ec4j that I wrote together with @angelozerr . In ec4j, we already have an abstraction of a Resource that would allow you to implement the Git backed kind of resource tree you need. We already have ClassPath resource, java.nio.Path resource and a plain string resource. I think especially the ClassPathResource very much resembles what you'd do for Git: https://github.com/ec4j/ec4j/blob/master/core/src/main/java/org/ec4j/core/Resource.java#L77 Feel free to file an issue at https://github.com/ec4j/ec4j/issues if our API is not flexible enough for you.

@kounoike
Copy link
Author

@ppalaga Thanks! I changed dependency from editorconfig-core to ec4j. I wrote JGitResource and JGitResourcePath in here. It doesn't require ec4j-core changes.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 21, 2018

Nice to hear that, @kounoike ! Could you please add GitBucket to "who is using ec4j" section of our README, once your change is merged? https://github.com/ec4j/ec4j#who-is-using-ec4j

@kounoike
Copy link
Author

kounoike commented Jul 1, 2018

@ppalaga Hi! gitbucket/gitbucket#1966 is merged! Thanks for your suggestion and proposal. @takezoe what do you think of this proposal?

@takezoe
Copy link

takezoe commented Jul 1, 2018

No problem at all about adding GitBucket to the list of ec4j users. Thanks for the useful library. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants