GHA update #121
GHA update #121
Conversation
|
Yes, if you can, please update pcre2 for windows build. We don't publish windows build yet, but PR is welcome. |
|
See , so it is pretty easy to change the PCRE2 version used by the build. I will update to latest release https://github.com/PCRE2Project/pcre2/releases/tag/pcre2-10.45 |
- adapt artifact to contain just content of build dir
- revert ubuntu changes
… github.ref_name which could be an invalid filename - just the artifact name is manipulated to contain the short sha, the inner zip hasn't it
chcg
force-pushed
the
gha_upload_artifacts
branch
from
8bdd9f3 to
583ff30
Compare
|
Awesome! Is this PR ready for review? I can change the required checks accordingly. |
|
@xuhdev PR is now ready for review |
| uses: softprops/action-gh-release@v2 | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| with: | ||
| files: editorconfig-core-c_${{ env.SHORT_SHA }}_${{ matrix.build_platform }}.zip |
There was a problem hiding this comment.
It's ideal if we can rename this file to include the tag here, but we can do it in a separate PR as an improvement (if it's not too hard :)).
There was a problem hiding this comment.
Sorry I misunderstood you in #121 (comment) . Based on https://github.com/softprops/action-gh-release?tab=readme-ov-file#inputs , it looks like we can just use github.ref_name to access the tag name. Do you think it's possible to rename the file when making a release?
I'm thinking about something like this before the creating release step:
- name: Rename
if: startsWith(github.ref, 'refs/tags/')
run: mv editorconfig-core-c_${{ env.SHORT_SHA }}_${{ matrix.build_platform }}.zip editorconfig-core-c_${{ github.ref_name }}_${{ matrix.build_platform }}.zip(If it's still too hard, don't worry about it. It's not a big issue.)
There was a problem hiding this comment.
Indeed that could be an option if adapted for powershell or cmd as it is needed for windows
Open topics: