-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsdoc types processing added, refs #88. #97
Conversation
If you think the types are not specific enough (It is admittedly more of a workaround) I see two alternatives:
|
Your workaround is fine. Just update package.json to specify types file. Check this example: https://github.com/editor-js/header/blob/master/package.json#L19-L25 |
A line with the types path should be already included in package.json. Or am I misunderstanding something? |
You should also declare "types" property on the root level |
Thanks a lot. I added it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update a patch version, please
Done. |
Is there anything else to fix? |
Thanks, @Sozialarchiv. Nice job. If you want to continue contributing, let me know |
If you agree I would like to add this types-patch to the other core plugins without types. It is imho a pragmatic way to solve the missing types and it is wished by several people: codex-team/editor.js#2660 In addition my plan is to solve some smaller issues which were complained about by our users. There are already pull requests for some of them. I will test and give feedback there. |
I have seen that some plugins are already written in typescript. Alternatively, I can also make typescript migrations if desired. However, such migrations can lead to merge conflicts with existing pull requests, which may initially speak in favor of the jsdoc workaround. |
Let's add such patch to the Table block. |
|
With this pr a types file gets automatically generated during build.