Skip to content

Conversation

@jinlinGuan
Copy link
Contributor

close #5317

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.06%. Comparing base (5ff0a09) to head (91370b8).

Files with missing lines Patch % Lines
...nternal/core/metadata/application/deviceprofile.go 0.00% 17 Missing ⚠️
internal/core/metadata/router.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5320      +/-   ##
==========================================
+ Coverage   21.01%   21.06%   +0.05%     
==========================================
  Files         284      284              
  Lines       20870    20907      +37     
==========================================
+ Hits         4386     4405      +19     
- Misses      16131    16149      +18     
  Partials      353      353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion regarding the wording in the OpenAPI document.

type: string
description: "The unique name of a device profile"
patch:
summary: "Allows adding/updating device resources/device commands tags field to an existing device profile. Deleting existing tags is not supported."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: "Allows adding/updating device resources/device commands tags field to an existing device profile. Deleting existing tags is not supported."
summary: "Allows adding or updating the tags field for device resources or device commands within an existing device profile. Removing existing tags is not supported."

@sonarqubecloud
Copy link

@jinlinGuan jinlinGuan requested a review from judehung November 27, 2025 08:32
Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judehung judehung merged commit 4d6b800 into edgexfoundry:main Nov 27, 2025
7 checks passed
@jinlinGuan jinlinGuan deleted the issue-5317 branch November 27, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Patch API to update device resoruce/commands tags in a device profile

3 participants