-
Notifications
You must be signed in to change notification settings - Fork 506
feat: Add PATCH tags API to core-metadata #5320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b66288e to
c5b33fc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5320 +/- ##
==========================================
+ Coverage 21.01% 21.06% +0.05%
==========================================
Files 284 284
Lines 20870 20907 +37
==========================================
+ Hits 4386 4405 +19
- Misses 16131 16149 +18
Partials 353 353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
judehung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion regarding the wording in the OpenAPI document.
openapi/core-metadata.yaml
Outdated
| type: string | ||
| description: "The unique name of a device profile" | ||
| patch: | ||
| summary: "Allows adding/updating device resources/device commands tags field to an existing device profile. Deleting existing tags is not supported." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| summary: "Allows adding/updating device resources/device commands tags field to an existing device profile. Deleting existing tags is not supported." | |
| summary: "Allows adding or updating the tags field for device resources or device commands within an existing device profile. Removing existing tags is not supported." |
close edgexfoundry#5317 Signed-off-by: Ginny Guan <[email protected]>
c5b33fc to
91370b8
Compare
|
judehung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



close #5317
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)