Skip to content

Conversation

@FelixTing
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

weichou1229 and others added 3 commits October 16, 2025 21:08
Since the cache share data, the map and slice should be cloned to prevent concurrent read write error.

Closes edgexfoundry#1710

Signed-off-by: bruce <[email protected]>
Signed-off-by: FelixTing <[email protected]>
@FelixTing
Copy link
Member Author

TODO: Update the versions of the following go modules in go.mod

	github.com/edgexfoundry/go-mod-bootstrap/v4
	github.com/edgexfoundry/go-mod-core-contracts/v4
	github.com/edgexfoundry/go-mod-messaging/v4

@FelixTing
Copy link
Member Author

recheck

@FelixTing FelixTing requested a review from judehung October 27, 2025 02:20
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 76.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.73%. Comparing base (5620c64) to head (b796965).

Files with missing lines Patch % Lines
internal/transformer/transformparam.go 0.00% 8 Missing ⚠️
internal/transformer/transformresult.go 86.95% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           odessa    #1773      +/-   ##
==========================================
+ Coverage   32.39%   32.73%   +0.34%     
==========================================
  Files          51       51              
  Lines        4887     4921      +34     
==========================================
+ Hits         1583     1611      +28     
- Misses       3166     3172       +6     
  Partials      138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judehung judehung merged commit bea3c83 into edgexfoundry:odessa Nov 12, 2025
3 checks passed
@FelixTing FelixTing deleted the pick-fix-from-main branch November 12, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants