Set src element on inference bus messages#54
Merged
Merged
Conversation
The video inference element posted its Element messages with gst::message::Element::new, which leaves the message src unset. Bus consumers rely on src to attribute each message to the element that produced it, so unattributed messages can't be matched back to this element on shared buses with multiple inference variants. Build the messages with Element::builder(s).src(&*self.obj()).build() at every post site in the video element (inference results, error, visual-anomaly, object-tracking, and classification fallbacks) so each message carries its producing element. Add an e2e regression test asserting that inference element messages expose a non-empty src.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The video inference element posted its Element messages with gst::message::Element::new, which leaves the message src unset. Bus consumers rely on src to attribute each message to the element that produced it, so unattributed messages can't be matched back to this element on shared buses with multiple inference variants.
Build the messages with Element::builder(s).src(&*self.obj()).build() at every post site in the video element (inference results, error, visual-anomaly, object-tracking, and classification fallbacks) so each message carries its producing element.
Add an e2e regression test asserting that inference element messages expose a non-empty src.