Fix overlay not drawing in cross-variant pipelines#53
Merged
Conversation
In multi-variant pipelines (e.g. videoinfer_34 → videoinfer_35 →
overlay_34), two bugs prevented the overlay from rendering:
1. VideoRegionOfInterestMeta (bounding boxes) was silently dropped
when passing through a downstream NeverInPlace videoinfer element.
GStreamer's default transform_meta rejects metas with API tags
(video, size), while tagless custom metas survived. Override
transform_meta to preserve all upstream metadata.
2. The overlay's typed meta::<VideoClassificationMeta>() lookup matched
by GType, so overlay variant 34 could never find classification
metadata registered by variant 35. Replace with name-prefix iteration
over all buffer metas and unsafe cast to the shared repr(C) layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-variant pipelines (e.g. videoinfer_34 → videoinfer_35 →
overlay_34), two bugs prevented the overlay from rendering:
VideoRegionOfInterestMeta (bounding boxes) was silently dropped when passing through a downstream NeverInPlace videoinfer element. GStreamer's default transform_meta rejects metas with API tags (video, size), while tagless custom metas survived. Override transform_meta to preserve all upstream metadata.
The overlay's typed meta::() lookup matched by GType, so overlay variant 34 could never find classification metadata registered by variant 35. Replace with name-prefix iteration over all buffer metas and unsafe cast to the shared repr(C) layout.