Skip to content

[WIP] Removed shares and some references to Merkle tree#1

Draft
ParthSareen wants to merge 2 commits into
masterfrom
parthsareen/UpdateSnapshotShrine
Draft

[WIP] Removed shares and some references to Merkle tree#1
ParthSareen wants to merge 2 commits into
masterfrom
parthsareen/UpdateSnapshotShrine

Conversation

@ParthSareen
Copy link
Copy Markdown
Collaborator

Removing references to MerkleTree in SnapshotShrine

Comment thread src/shrines/SnapshotShrine.sol Outdated
/// -----------------------------------------------------------------------

// TODO: Update below notice to reflect structure
/// @notice Offer ERC-20 tokens to the MerkleShrine and distribute them to Champions proportional
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC we the structure is similar except we won't be calling it MerkleShrine - should we just change to SnapshotShrine or do we want a diff name

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaoDeCyrus

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, Merkle => Snapshot @ParthSareen

@ParthSareen
Copy link
Copy Markdown
Collaborator Author

ParthSareen commented Nov 5, 2022

TODO:

  • Finish updating SnapshotShrine
  • Tests for changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants