feat(menu-bar): add monochrome icon mode#24
Merged
Conversation
eddmann
force-pushed
the
codex/monochrome-icon-toggle
branch
from
111131e to
06743f5
Compare
Adds a Mono/Color setting in General so the menu bar icon can render as an NSImage template and inherit the system menu bar tint. Color remains the default to preserve current behavior. This addresses the feature proposed by @jeanfw in #16 with a smaller renderer-level implementation: icon styles stay unchanged, and MenuBarIconRenderer owns the NSImage.isTemplate translation. The settings preview cards now use the same renderer path as the real menu bar icon, and settings decoding defaults missing is_colored_icon values to color for existing saved preferences.
eddmann
force-pushed
the
codex/monochrome-icon-toggle
branch
from
06743f5 to
0cce874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSImage.isTemplate, so the icon follows the system menu bar tint.is_colored_iconis absent.Attribution
Thanks again to @jeanfw for the great change idea and original proposal in #16. This PR keeps the same user-facing goal while applying it at the renderer/cache layer so the existing icon styles remain unchanged.
Screenshots