Avoid overflow in DAB Monobit2 test. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With default ntup 0, the DAB Monobit 2 test tries to select maximum block, but only up to the fixed BLOCK_MAX. User can override the test with ntup value (-n option) but as there are fixed allocation of pvalues, only values up to BLOCK_MAX-1 (15) are allowed. (Increasing BLOCK_MAX would cause malloc to fail anyway.) Skipping automatic block size detection could also cause test to fail if there is not enough samples. Fix possible overflow by exiting the program with an error message as there is no proper invalid return code check (as seen in other tests too). Segfault/overflow easily reproducible with truncate -s 256M test.img dieharder/dieharder -n 32 -d 209 -g 201 -f test.img
eddelbuettel
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With default ntup 0, the DAB Monobit 2 test tries to select maximum block, but only up to the fixed BLOCK_MAX.
User can override the test with ntup value (-n option) but as there are fixed allocation of pvalues, only values up to BLOCK_MAX-1 (15) are allowed.
(Increasing BLOCK_MAX would cause malloc to fail anyway.)
Skipping automatic block size detection could also cause test to fail if there is not enough samples.
Fix possible overflow by exiting the program with
an error message as there is no proper invalid return code check (as seen in other tests too).
Segfault/overflow easily reproducible with
truncate -s 256M test.img
dieharder/dieharder -n 32 -d 209 -g 201 -f test.img