Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated files, gcc warning fixes #20

Merged
merged 6 commits into from
Jan 27, 2024

Conversation

mbroz
Copy link
Contributor

@mbroz mbroz commented Jan 27, 2024

Some easy fixes, split per patches:

  • update auto-generated files after added new tests (otherwise it is changed during compilation) (automake from Debian)
  • some gcc warning fixes (no functional chcnges, though :)
  • fix the new Birthday test name to not collide with original Diehard one (id 0 vs id 210).

There are more gcc warnings, but these will need real fixes.

If you want to drop some patch from this series, let me know please.

@eddelbuettel
Copy link
Owner

Love love love what you are doing. Much appreciated.

One place to keep an eye on too is https://github.com/eddelbuettel/rdieharder because for 'reasons' I rejigged that after a few years of requiring the external library and made it internal. Which ... created of course yet another copy. But that one gets rebuilt all the time by CRAN so I get nags about changes for newer gcc and so on. So we want that input here to. In time.

@eddelbuettel eddelbuettel merged commit a186d90 into eddelbuettel:master Jan 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants