63 setup exploration module #69

pveeckhout · 2023-07-25T20:11:39Z

adding exploration module

process NavRoute EDDN message
process request for system Coordinates from trade module

write endpoint for system search by name from searchbar

transition to PostGIS from Postgress

closes #63

…ration-module

… 63-setup-exploration-module

…search bar (autocompletion)

officialyinsane · 2023-07-25T20:17:05Z

boot/src/main/java/io/edpn/backend/application/controller/BootExplorationModuleController.java

+public class BootExplorationModuleController extends DefaultExplorationModuleController {
+
+    public BootExplorationModuleController(FindSystemsFromSearchbarUseCase findSystemsFromSearchbarUseCase, SystemDtoMapper systemDtoMapper) {
+        super(findSystemsFromSearchbarUseCase, systemDtoMapper);


"from search bar" - isn't that a FE concept? Should we not use the filters logic?

the issue is that this is indeed an endpoint, that were it not for FE, I would not have created.

this is such a specific need to have performant and limited resultSet that I think it warants a specific endpoint

docker-compose-localdev.yml

docker-compose.yml

...o/edpn/backend/exploration/application/controller/v1/DefaultExplorationModuleController.java

...va/io/edpn/backend/exploration/application/usecase/DefaultReceiveNavRouteMessageUseCase.java

...n/backend/exploration/application/usecase/DefaultReceiveSystemCoordinatesRequestUseCase.java

exploration-module/src/main/java/io/edpn/backend/exploration/configuration/ServiceConfig.java

...module/src/main/java/io/edpn/backend/exploration/infrastructure/kafka/KafkaTopicHandler.java

exploration-module/src/main/java/io/edpn/backend/exploration/application/dto/SystemEntity.java

exploration-module/src/main/java/io/edpn/backend/exploration/adapter/web/SystemController.java

.../main/java/io/edpn/backend/trade/application/controller/v1/DefaultTradeModuleController.java

.../java/io/edpn/backend/exploration/adapter/persistence/SystemCoordinateRequestRepository.java

...o/edpn/backend/exploration/adapter/persistence/MybatisSystemCoordinateRequestRepository.java

docker-compose.yml

exploration-module/src/main/java/io/edpn/backend/exploration/adapter/config/KafkaConfig.java

...o/edpn/backend/exploration/adapter/persistence/MybatisSystemCoordinateRequestRepository.java

officialyinsane · 2023-08-05T16:23:28Z

...io/edpn/backend/exploration/adapter/persistence/entity/mapper/MybatisSystemEntityMapper.java

+                system.starClass(),
+                Optional.ofNullable(system.coordinate()).map(Coordinate::x).orElse(null),
+                Optional.ofNullable(system.coordinate()).map(Coordinate::y).orElse(null),
+                Optional.ofNullable(system.coordinate()).map(Coordinate::z).orElse(null));


In what situation would a system not have an x/y/z co-ordinate?

Should these not be non-null? Maybe we know the system name, but not it's location (thanks to EDDN design decisions)? I know there are some message types that state the system name but not it's location (my choice to address that in the past, was to make System have an address property, which may or may not be null... but an address must always have x/y/z).

exploration-module/src/main/java/io/edpn/backend/exploration/adapter/web/SystemController.java

officialyinsane · 2023-08-05T16:27:06Z

...le/src/main/java/io/edpn/backend/exploration/adapter/web/dto/mapper/RestSystemDtoMapper.java

+
+    private CoordinateDto coordinateFromSystem(System system) {
+        if (Optional.ofNullable(system.coordinate()).map(Coordinate::x).isEmpty()) {
+            return null;


I'm going to be flamed for this, but this is a misuse of Optional in my opinion.

This could be a rather simple if construct, possibly a ternary. It could even be Objects.requireNonNull().

Also, the isEmpty() if-block could be orElse(null) instead.

But is null really something we'd want to return here?

officialyinsane · 2023-08-05T16:29:28Z

...le/src/main/java/io/edpn/backend/exploration/application/service/ReceiveNavRouteService.java

+
+    private System updateSystemFromItem(final System system, NavRouteMessage.V1.Item item) {
+        System returnSystem = system;
+        if (Objects.isNull(system.eliteId())) {


What's wrong with if system.eliteId() == null ?

...n/java/io/edpn/backend/exploration/application/validation/LoadByNameContainingValidator.java

Daniel-J-Mason

I dont see the files for marking,
io/edpn/backend/trade/application/dto/v1/LocateCommodityResponse.java
Line 21
java.time.LocalDateTime not supported by jacksonized out of the box, error message says to add "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling

...le/src/main/java/io/edpn/backend/exploration/adapter/web/dto/mapper/RestSystemDtoMapper.java

exploration-module/src/main/java/io/edpn/backend/exploration/adapter/web/SystemController.java

Daniel-J-Mason

Approved

Pieter Van Eeckhout and others added 14 commits July 20, 2023 00:08

#63 - creating project, adding basic classes and placeholders

718738c

#63 - adding processing of data request

690280f

Merge remote-tracking branch 'origin/development' into 63-setup-explo…

582f855

…ration-module

#63 - moving config to correct folder

9b85a9b

#63 - adding processing of NavRouteV1Message

7fb7c11

#63 - adding config for running the two modules alongside each other

3133a44

#63 - improving inter module communication

c8d68a3

#63 - adding config for running the two modules alongside each other

6cb012d

#63 - fixing broken tests

339b045

Merge remote-tracking branch 'origin/45-whitelist-for-commodity' into…

e2d087b

… 63-setup-exploration-module

#63 - adding controller and endpoint for allowing system search from …

de37817

…search bar (autocompletion)

#63 - adding tests

02b85c9

#63 - fixing missing starClass

286e60e

#63 - switching to postGIS

8742e9a

pveeckhout requested review from officialyinsane and a team July 25, 2023 20:11

pveeckhout assigned Daniel-J-Mason Jul 25, 2023

pveeckhout linked an issue Jul 25, 2023 that may be closed by this pull request

setup Exploration module #63

Closed

pveeckhout removed the request for review from officialyinsane July 25, 2023 20:11

Merge branch 'development' into 63-setup-exploration-module

a28298c

pveeckhout added this to the exploration-module milestone Jul 25, 2023