Refactor commodity repository and update database schema #158
Conversation
Updated MybatisCommodityRepository, replacing several methods with a createOrUpdateOnConflict method and added new pertinent fields to the database table "commodity". This includes adding and renaming columns, updating the "validated_commodity_view" and adding an index for the "is_rare" column. In "build.gradle", the backendMessageProcessorLibVersion has been updated.
In the 'ReceiveCommodityMessageUseCaseTest.java', two new null parameters were added to the 'CommodityMessage.V3.Payload()' invocation. This aligns with recent schema updates to the Commodity Message functionality.
There was a problem hiding this comment.
validated_commodity may be useful to query, but in the spirit of merging these entities I think the entire ValidatedCommodity application class should be removed from the backend stack. The Commodity class should be updated to include the full field set and be the sole reference so cut down on confusion. We havent separated any of our other classes based on completeness either so this would be a more consistent approach
There was a problem hiding this comment.
This breaks liquibase changelog checksum, have to recreate in a new file. maybe something like update_validated_commodity_view.xml
May come up with a standard naming system if we have multiple updates
There was a problem hiding this comment.
this should not break the checksum as it should always do a recreate upon start.
The settings of the validated_commodity_view have been updated to run on change, in addition to running always. The 'create_validated_commodity_view' changeset in 'create_validated_commodity_view.xml' now includes 'runOnChange' making the database changes more responsive to modifications.
pveeckhout
deleted the
157-merge-commodity-and-commodity_whitelist-tables-to-improve-query-performance
branch
Updated MybatisCommodityRepository, replacing several methods with a createOrUpdateOnConflict method and added new pertinent fields to the database table "commodity". This includes adding and renaming columns, updating the "validated_commodity_view" and adding an index for the "is_rare" column. In "build.gradle", the backendMessageProcessorLibVersion has been updated.
closes #157