153-Database-Connection-BugFix #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt but the check is to see if the request is needed, rather than should it insert into local table.
pveeckhout
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First revision to try and correct connection bug.
Trade module IMC was throwing primary key conflicts as duplicate requests were being logged to the table in certain parallel processing cases.
This was due to backend checking with databse before insert, in that turn around time multple requests were stacking for the same system/station combo. Updated to match exploration IMC and regular databases to createIfNotExists allowing the database to handle ON CONFLICT cases itself.
This was likely slowly consuming the full connection pool which locked the rest of the system from continuing to interact with the database. This change is a needed fix regardless of whether its the true root causes of the larger issue.