151 increase trade query performance #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redundant interfaces related to DTOs, Entity and Mappers from the trading module have been deleted. This clean-up action was undertaken to simplify the codebase and remove excessive constraining of adapters, thereby improving project maintainability.
Classes in the backend trade adapter module have been renamed to improve clarity and maintain convention. These changes include the addition of prefixes like Mybatis and Rest to indicate the context of the class.
Adjusted how message objects are created and used in multiple test and service files. Removed unnecessary assertion lines and streamlined code for cleaner, simplified logic for request port service tests. Updated how JsonNode objects are used in inter-module communication service.
The addition of five different mapper classes to the BootTradeModuleController was completed. These mappers bring about a new functionality to map data transfer objects (DTOs) to domain objects. The change will affect the way data is processed within the BootTradeModuleController, hence enhancing its functionality and encapsulation adherence.
…nto streamline-hexagone-structure
Several DTO, entity, and mapper classes related to the exploration-module have been deleted. This significant cleanup removes unnecessary code related to several classes like BodyDto, StarEntity, and StationMaxLandingPadSizeRequestEntity. The elimination of these files may impact functionality, so other solutions should be considered for the functionalities they provided.
pricing may not need indexing for trade algo but will improve commodity look up and commodity market view Add index for station arrival distance
…ckend into 151-Increase-trade-query-performance
pveeckhout
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add b-tree index to latest_market_data buy_price, sell_price, demand, stock
Add b-tree index to station arrival_distance