-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#103 - adding pagination #104
Draft
pveeckhout
wants to merge
15
commits into
development
Choose a base branch
from
103-add-pagination-to-locate-commodityfilter-endpoint
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4ce3f74
#103 - adding pagination
5dfa58d
#103 - changing to implementation to facilitate swagger documentation
a512ec5
#103 - adding schema
pveeckhout c241636
#103 - wip returning pageInfo in result
pveeckhout 596f0b7
Merge branch 'development' into 103-add-pagination-to-locate-commodit…
pveeckhout f856272
#103 - improving pageInfo returned
pveeckhout bd97a6e
Merge branch 'development' into 103-add-pagination-to-locate-commodit…
pveeckhout 1a54e03
Merge branch 'development' into 103-add-pagination-to-locate-commodit…
pveeckhout c9e3559
Merge remote-tracking branch 'origin/development' into 103-add-pagina…
20b4ab8
Merge branch 'development' into 103-add-pagination-to-locate-commodit…
pveeckhout b1db673
Merge remote-tracking branch 'origin/development' into 103-add-pagina…
pveeckhout 800bebc
#103 - fixing outdated qualifier
pveeckhout 0fc099a
#103 -adding paging request info directly on the filter object
pveeckhout 8bd8cde
#103 - fixing generics issue with swagger
pveeckhout a9c494f
Merge remote-tracking branch 'origin/development' into 103-add-pagina…
pveeckhout File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
import io.edpn.backend.trade.application.dto.web.object.mapper.CommodityMarketInfoDtoMapper; | ||
import io.edpn.backend.trade.application.dto.web.object.mapper.LocateCommodityDtoMapper; | ||
import io.edpn.backend.trade.application.dto.web.object.mapper.MessageMapper; | ||
import io.edpn.backend.trade.application.dto.web.object.mapper.PageInfoDtoMapper; | ||
import io.edpn.backend.trade.application.dto.web.object.mapper.ValidatedCommodityDtoMapper; | ||
import io.edpn.backend.trade.application.port.incomming.kafka.RequestDataUseCase; | ||
import io.edpn.backend.trade.application.port.outgoing.commodity.LoadOrCreateCommodityByNamePort; | ||
|
@@ -78,8 +79,9 @@ public FindCommodityMarketInfoService findCommodityMarketInfoService( | |
public LocateCommodityService locateCommodityService( | ||
LocateCommodityByFilterPort locateCommodityByFilterPort, | ||
LocateCommodityFilterDtoMapper locateCommodityFilterDtoMapper, | ||
LocateCommodityDtoMapper locateCommodityDtoMapper) { | ||
return new LocateCommodityService(locateCommodityByFilterPort, locateCommodityFilterDtoMapper, locateCommodityDtoMapper); | ||
LocateCommodityDtoMapper locateCommodityDtoMapper, | ||
PageInfoDtoMapper pageInfoDtoMapper) { | ||
return new LocateCommodityService(locateCommodityByFilterPort, locateCommodityFilterDtoMapper, locateCommodityDtoMapper, pageInfoDtoMapper); | ||
} | ||
|
||
@Bean(name = "tradeRecieveCommodityMessageUsecase") | ||
|
@@ -201,7 +203,7 @@ public RequestMissingSystemCoordinatesService requestMissingSystemCoordinatesUse | |
CreateSystemCoordinateRequestPort createSystemCoordinateRequestPort, | ||
SendKafkaMessagePort sendKafkaMessagePort, | ||
@Qualifier("tradeRetryTemplate") RetryTemplate retryTemplate, | ||
@Qualifier("tradeThreadPoolTaskExecutor") Executor executor, | ||
@Qualifier("tradeForkJoinPool") Executor executor, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I cant comment the line apparently, line 246 for tradeRequestMissingStationRequireOdysseyUseCase bean has an invalid executor qualifier now. Revise |
||
ObjectMapper objectMapper, | ||
MessageMapper messageMapper | ||
) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic number and a TODO tag, should we not have these summarised in some issue? Maybe deal with it all under one issue?
Ideally, should be configurable.