Refactor Collective and Project scopes and methods

app/controllers/audit_controller.rb

@@ -12,15 +12,15 @@ def no_projects
   end
 
   def no_license
-    @collectives = Collective.where(projects_count: 1).select{|c| c.projects.first && c.projects.first.repository && !c.projects.first.repository['archived'] && c.projects.first.repository['license'].blank?}
+    @collectives = Collective.with_projects.order(transactions_count: :desc).select{|c| c.no_license? }
   end
 
   def archived
-    @collectives = Collective.where(projects_count: 1).select{|c| c.projects.first && c.projects.first.repository && c.projects.first.repository['archived']}
+    @collectives = Collective.with_projects.order(transactions_count: :desc).select{|c| c.archived? }
   end
 
   def inactive
-    @collectives = Collective.select{|c| c.inactive?}
+    @collectives = Collective.with_projects.order(transactions_count: :desc).select{|c| c.inactive? }
   end
 
   # collectives with no funding links

app/models/collective.rb

@@ -9,7 +9,7 @@ class Collective < ApplicationRecord
 
   scope :with_transactions, -> { where.not(transactions_count: 0) }
 
-  scope :with_repository, -> { where.not(repository: nil) }
+  scope :with_projects, -> { where.not(projects_count: 0) }
 
   scope :with_owner, -> { where.not(owner: nil) }
   scope :with_org_owner, -> { with_owner.where("owner ->> 'kind' = 'organization'") }
@@ -55,6 +55,14 @@ def inactive?
     last_project_activity_at < 1.year.ago
   end
 
+  def archived?
+    projects.all?{|p| p.archived? }
+  end
+
+  def no_license?
+    projects.all?{|p| p.no_license? }
+  end
+
   def sync_async
     SyncCollectiveWorker.perform_async(id)
   end

app/models/project.rb

@@ -176,6 +176,14 @@ def open_source_license?
     (packages_licenses + [repository_license]).compact.uniq.any?
   end
 
+  def no_license?
+    !open_source_license?
+  end
+
+  def packages_licenses
+    [] # TODO
+  end
+
   def archived?
     return false unless repository.present?
     repository['archived']