Refactor transaction scopes and add transaction_kind attribute

app/models/collective.rb

@@ -302,7 +302,8 @@ def sync_transactions
           uuid: node['uuid'],
           amount: node['amount']['value'],
           net_amount: node['netAmount']['value'],
-          kind: node['type'],
+          transaction_type: node['type'],
+          transaction_kind: node['kind'],
           currency: node['amount']['currency'],
           account: node['type'] == 'DEBIT' ? node['toAccount']['slug'] : node['fromAccount']['slug'],
           created_at: node['createdAt'],

app/models/transaction.rb

@@ -4,8 +4,8 @@ class Transaction < ApplicationRecord
 
   counter_culture :collective, execute_after_commit: true
 
-  scope :donations, -> { where(kind: 'CREDIT') }
-  scope :expenses, -> { where(kind: 'DEBIT') }
+  scope :donations, -> { where(transaction_type: 'CREDIT') }
+  scope :expenses, -> { where(transaction_type: 'DEBIT') }
   scope :host_fees, -> { where(description: "Host Fee")}
   scope :not_host_fees, -> { where.not(description: "Host Fee")}
   scope :created_after, ->(date) { where('created_at > ?', date) }

db/migrate/20240118155013_add_kind_to_transactions.rb

@@ -0,0 +1,6 @@
+class AddKindToTransactions < ActiveRecord::Migration[7.1]
+  def change
+    add_column :transactions, :transaction_kind, :string
+    rename_column :transactions, :kind, :transaction_type
+  end
+end