-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve all outstanding warnings on rendering documentation #1301
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 72.55% 72.55%
=======================================
Files 78 78
Lines 13009 13009
=======================================
Hits 9439 9439
Misses 3570 3570
☔ View full report in Codecov by Sentry. |
The failure is:
@MridulS please could you confirm on this? I can't re-run failing jobs it seems, it might just be a flaky test. A |
Yeah re-running this made CI happy, seems to be a flaky numba/windows test. |
Looks good! builds locally without any warnings :) |
This PR fixes all Sphinx warnings, and enables the 'fail on warnings' mode to ensure no future regressions.
Of note:
ARKitecture.md
has been changed to Commonmark-compliant syntax\,\!
construct to preserve indentation within the notebookA