Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve all outstanding warnings on rendering documentation #1301

Merged
merged 19 commits into from
Jul 13, 2023

Conversation

AA-Turner
Copy link
Collaborator

This PR fixes all Sphinx warnings, and enables the 'fail on warnings' mode to ensure no future regressions.

Of note:

A

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (37134b9) 72.55% compared to head (8bd85bb) 72.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1301   +/-   ##
=======================================
  Coverage   72.55%   72.55%           
=======================================
  Files          78       78           
  Lines       13009    13009           
=======================================
  Hits         9439     9439           
  Misses       3570     3570           
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsIndShockModel.py 87.04% <ø> (ø)
HARK/ConsumptionSaving/ConsRiskyContribModel.py 79.81% <ø> (ø)
HARK/distribution.py 83.26% <ø> (ø)
HARK/frame.py 84.89% <ø> (ø)
HARK/interpolation.py 43.31% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AA-Turner
Copy link
Collaborator Author

The failure is:

worker 'gw1' crashed while running 'HARK/ConsumptionSaving/tests/test_IndShockConsumerTypeFast.py::testBufferStock::test_infinite_horizon'

@MridulS please could you confirm on this? I can't re-run failing jobs it seems, it might just be a flaky test.

A

@MridulS
Copy link
Member

MridulS commented Jul 13, 2023

@MridulS please could you confirm on this? I can't re-run failing jobs it seems, it might just be a flaky test.

Yeah re-running this made CI happy, seems to be a flaky numba/windows test.

@MridulS
Copy link
Member

MridulS commented Jul 13, 2023

Looks good! builds locally without any warnings :)
Thanks @AA-Turner !

@MridulS MridulS merged commit 09f1843 into econ-ark:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants