-
Notifications
You must be signed in to change notification settings - Fork 27
Fixes the CI if condition #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #183 +/- ##
========================================
Coverage 64.71% 64.71%
========================================
Files 1101 1101
Lines 55738 55738
Branches 4204 4204
========================================
+ Hits 36071 36072 +1
+ Misses 19667 19666 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Private downstream CI failed. |
Private downstream CI failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what we have in other downstreams as well.
Just started to wonder about the reason for having success() || failure()
... seems to always happen, or are there other states like skipped()
?
I think it's cancelled. all our repos have it outside the "${{" but not sure which form is correct. or maybe we need |
Private downstream CI succeeded. |
1 similar comment
Private downstream CI succeeded. |
No description provided.