Skip to content

Fixes the CI if condition #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixes the CI if condition #183

wants to merge 2 commits into from

Conversation

mcakircali
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.71%. Comparing base (d2bd118) to head (4d3ea49).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #183   +/-   ##
========================================
  Coverage    64.71%   64.71%           
========================================
  Files         1101     1101           
  Lines        55738    55738           
  Branches      4204     4204           
========================================
+ Hits         36071    36072    +1     
+ Misses       19667    19666    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14083413580.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14085058936.

Copy link
Contributor

@geier1993 geier1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what we have in other downstreams as well.

Just started to wonder about the reason for having success() || failure() ... seems to always happen, or are there other states like skipped() ?

@mcakircali
Copy link
Contributor Author

that's what we have in other downstreams as well.

Just started to wonder about the reason for having success() || failure() ... seems to always happen, or are there other states like skipped() ?

I think it's cancelled. all our repos have it outside the "${{" but not sure which form is correct. or maybe we need !cancelled() .. I don't know

Copy link

github-actions bot commented Apr 4, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14263248192.

1 similar comment
Copy link

github-actions bot commented Apr 4, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14263248192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants