Skip to content

fix VNumberInput import dependency in vuetify > 3.8.0 #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

viktor-c
Copy link

@viktor-c viktor-c commented Apr 5, 2025

Fix #2434

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Apr 5, 2025

Deploy Preview for jsonforms-examples failed.

Name Link
🔨 Latest commit ca0b0ef
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6808a4215e3e450008c62150

@lucas-koehler
Copy link
Contributor

Hi @viktor-c , thanks for the contribution ❤️
However, your changes are not sufficient: Currently, we allow vuetify ^3.6.6 in the peer dependencies of the vue-vuetify package. With this, your changes do not work.
We need to increase the version range to ^3.8.0. We can do this. Please adapt the PR accordingly :)

@coveralls
Copy link

coveralls commented Apr 23, 2025

Coverage Status

coverage: 82.517%. remained the same
when pulling ca0b0ef on viktor-c:master
into 5218263 on eclipsesource:master.

@lucas-koehler
Copy link
Contributor

Hi @viktor-c , Thanks for the update! I added the missing update for the dev dependency of vuetify ^3.8.0 and regenerated the pnpm lock file to use this.
Unfortunately, this seems to break the preview and affects the build on windows and mac.
Could you have a look what causes this?
Netlify preview build logs: https://app.netlify.com/sites/jsonforms-examples/deploys/6808a4215e3e450008c62150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VNumberInput is core component in vuetify > 3.8.0
4 participants