Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): add utility function to move vehicle reference position #374

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Jan 22, 2024

Description

  • Simulators may have different reference positions of vehicles, e.g. SUMO points on center of front bumper, while Carla and PHABMACS refer to the center of the vehicle's bounding box.
  • A later goal should be to generalize this across MOSAIC, so simulators may have to adjust the positions they put into VehicleData objects.
  • As a first step, this MR provides utility functions to conveniently convert from "front bumper" to "bb center" and vice versa for the 2D-case.

Issue(s) related to this PR

  • Resolves internal issue 767

Affected parts of the online documentation

Changes in the documentation required?

Not yet

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab added the enhancement New feature or request label Jan 22, 2024
@kschrab kschrab requested a review from schwepmo January 22, 2024 08:42
@schwepmo schwepmo merged commit 7430df8 into main Jan 23, 2024
6 checks passed
@schwepmo schwepmo deleted the 767-carla-adjustments branch January 23, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants