-
Notifications
You must be signed in to change notification settings - Fork 20
Open api async api ux support #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open api async api ux support #368
Conversation
✅ Deploy Preview for playground-testing ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Some todos:
|
Title attributes for all buttons would be nice. Also the JSON/YAML button is not the same size as the ones next to it |
We can try the YAML support with https://www.npmjs.com/package/js-yaml . It can be that some TDs cannot be converted back to JSON but let's try and see which cases break. We should put a warning to the left of the button saying the feature is experimental. |
The tests are actually passing but the netlify preview shows a console error that results in the page failing to load. No clear how a require is not defined but I am guessing a scoping issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems I have detected.
- Yaml conversion should be in the core since the CLI can use it in the future too
- If the initial TD is invalid JSON, converting to YAML has a weird behavior. I think this is due to line 164 in util.js
- invalid JSON should not even show the warning this is experimental pop up
Also, saving as a link has a weird behavior in yaml. A link is generated but it cannot be used |
@hasanheroglu it is looking pretty good. I did one minor change and will merge it once the tests pass. |
I have noticed two issues:
|
@hasanheroglu nice work! Merging this nice feature (set of features now ^_^) |
Closes #365