Ensure unique counters for editor widgets in a merge editor#17257
Closed
pisv wants to merge 1 commit intoeclipse-theia:masterfrom
Closed
Ensure unique counters for editor widgets in a merge editor#17257pisv wants to merge 1 commit intoeclipse-theia:masterfrom
pisv wants to merge 1 commit intoeclipse-theia:masterfrom
Conversation
3 tasks
Contributor
Author
|
Closing in favour of #17275. |
github-project-automation
bot
moved this from Waiting on reviewers
to Done
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #17256.
How to test
Please use the steps for reproducing #17256 to verify that the regular editor is now restored correctly. (Note that the merge editor is not expected to be restored at this time. It's a separate issue tracked in #17251.)
Breaking changes
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers