Skip to content

Conversation

@AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Jul 23, 2025

Updating the LICENSE and NOTICE files to latest version. Those files have been reviewed by Eclipse Experts. Please merge this PR if and only if your repository does not need special consideration.
Reference: eclipse-score/score#1218

Copilot AI review requested due to automatic review settings July 23, 2025 15:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the licensing documentation for the Eclipse Safe Open Vehicle Core project by replacing the current LICENSE.md file with a comprehensive NOTICE file and updating the LICENSE file to the standard Apache 2.0 license text.

  • Adds a new NOTICE file containing project metadata, copyright information, and licensing details
  • Removes the existing LICENSE.md file that contained a brief Apache 2.0 license statement
  • Updates the LICENSE file by removing the appendix section and adding a blank line at the beginning

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
NOTICE Adds comprehensive project notice with Eclipse Foundation details, trademarks, copyright, and cryptography information
LICENSE.md Removes the existing brief Apache 2.0 license file
LICENSE Updates to standard Apache 2.0 license by removing the appendix section and adding leading whitespace
Comments suppressed due to low confidence (1)

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
2025/08/11 07:08:32 Downloading https://releases.bazel.build/7.4.0/release/bazel-7.4.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 3f5b8ef7-1eef-49b3-81fe-3057230c26c0
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (94 packages loaded, 10 targets configured)

Analyzing: target //:license-check (97 packages loaded, 10 targets configured)

Analyzing: target //:license-check (128 packages loaded, 173 targets configured)

Analyzing: target //:license-check (151 packages loaded, 1775 targets configured)

Analyzing: target //:license-check (160 packages loaded, 2689 targets configured)

Analyzing: target //:license-check (160 packages loaded, 2689 targets configured)

Analyzing: target //:license-check (160 packages loaded, 2689 targets configured)

Analyzing: target //:license-check (163 packages loaded, 4706 targets configured)

Analyzing: target //:license-check (164 packages loaded, 4832 targets configured)

Analyzing: target //:license-check (165 packages loaded, 4952 targets configured)

Analyzing: target //:license-check (165 packages loaded, 4952 targets configured)

Analyzing: target //:license-check (165 packages loaded, 4952 targets configured)

INFO: Analyzed target //:license-check (166 packages loaded, 6871 targets configured).
[9 / 13] JavaToolchainCompileClasses external/rules_java~/toolchains/platformclasspath_classes; 0s disk-cache
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 224 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[11 / 13] JavaToolchainCompileBootClasspath external/rules_java~/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[12 / 13] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 194.894s, Critical Path: 2.90s
INFO: 13 processes: 9 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt -review -project automotive.score -repo https://github.com/eclipse-score/inc_orchestrator -token otyhZ4eaRYK1tKLNNF-Y
[main] INFO Querying Eclipse Foundation for license data for 224 items.
[main] INFO Found 119 items.
[main] INFO Querying ClearlyDefined for license data for 105 items.
[main] INFO Found 105 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/async_runtime/0.1.0
[main] INFO crate/cratesio/-/foundation/0.1.0
[main] INFO crate/cratesio/-/logging_tracing/0.1.0
[main] INFO crate/cratesio/-/rust_test_scenarios/0.1.0
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.
[main] INFO A review is required for crate/cratesio/-/rust_test_scenarios/0.1.0.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/22575 .
[main] INFO A review is required for crate/cratesio/-/foundation/0.1.0.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21861 .
[main] INFO A review is required for crate/cratesio/-/logging_tracing/0.1.0.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21880 .
[main] INFO A review is required for crate/cratesio/-/async_runtime/0.1.0.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21889 .

@pawelrutkaq
Copy link
Contributor

@AlexanderLanin can You fix check to merge this ?

@AlexanderLanin
Copy link
Member Author

By fix check you mean remove/adjust gitlint? I feel that falls into inc_orchestrator responsibility :-)

@pawelrutkaq
Copy link
Contributor

By fix check you mean remove/adjust gitlint? I feel that falls into inc_orchestrator responsibility :-)

@nic

@pawelrutkaq pawelrutkaq reopened this Aug 11, 2025
@pawelrutkaq
Copy link
Contributor

@dcalavrezo-qorix @nicu1989 isnt gitlint check Score global ? If not then we need to align here?

@nicu1989
Copy link
Member

nicu1989 commented Aug 13, 2025

@dcalavrezo-qorix @nicu1989 isnt gitlint check Score global ? If not then we need to align here?

Looks like we need to unify the git commit rules, meaning have a shared .gitlint file. @AlexanderLanin updated the SCORE .gitlint, but since inc_orchestrator has his own .gitlint I think it would be better if we consider a shared .gitlint . I will create a ticket.

Edit: eclipse-score/score#1626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants